[MPlayer-dev-eng] [PATCH] demux_pva fixes

Matteo Giani matteo.giani at gmail.com
Sat Oct 15 17:59:18 CEST 2011


Hi

On Thu, Oct 13, 2011 at 11:41 PM, Matteo Giani <matteo.giani at gmail.com>wrote:

> I will resubmit as separate patches against current svn as per Dominik's
> request as soon as I get the chance, hopefully over the weekend.
>

As per my previous message, resubmitting the changes split into two patches:
* a very small (2-line basically) patch fixing the two functional issues
* the overall patch including the above plus the cleanup points

>
> > Why did you leave the DEMUX_PVA_MULTIDEC_HACK one in?


> In the current form it effectively remains a "hack" so I did not want it to
> get forgotten, but happy to take out the #ifdef and comment appropriately.
> Libavformat actually works around this issue in a more elegant way (making
> use of length fields within the PES headers) which, for the sake of having
> tidier code, I will look into replicating here when I resubmit.
>

Removal of the #ifdef and replacement with cleaner detection (along the
lines of the FFmpeg PVA code) of PES packet length are included in the
attached cleanup patch.

Best regards,

Matteo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: demux_pva-20111015-fixes.diff
Type: text/x-patch
Size: 609 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20111015/899980e9/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: demux_pva-20111015-cleanups_and_fixes.diff
Type: text/x-patch
Size: 11042 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20111015/899980e9/attachment-0001.bin>


More information about the MPlayer-dev-eng mailing list