[MPlayer-dev-eng] MPlayer/MEncoder crash on using -vf scale and expand together. Fix attached.

[Reimar Döffinger]

On Fri, Oct 28, 2011 at 06:17:31PM +0530, Alex C wrote:
> Problem: SIGSEGV on mplayer -vf scale=720:480,expand=720:480 test.mkv
> 
> Sample test file: https://ffmpeg.org/trac/ffmpeg/attachment/ticket/594/rotate_x.mp4
> 
> Backtrace on: http://pastebin.com/uHPRtswz
> 
> Similar to ffmpeg bug: https://ffmpeg.org/trac/ffmpeg/ticket/594?cversion=1&cnum_hist=4
> 
> Patched in ffmpeg by michaelni: http://git.videolan.org/gitweb.cgi?p=ffmpeg.git;a=commitdiff;h=3e4375833d964ebb5d38816126ff0101ae696cf9;hp=d7dcd96a2377835a20c3d23b3bd476ddcf1baebb
> 
> I have applied a similar patch for mplayer. Patch is attached. The crash is averted as a result.

Patch is the wrong way round.
But anyway, the libswscale API does not mention such alignment
requirements, such alignment requirements cause real issues
(for many resolutions you can no longer scale directly into
a frame buffer or otherwise fixed-stride surface) and in general
it is an API change to require this now.
I very much think libswscale is broken.