[MPlayer-dev-eng] [PATCH] configure: fix ws2tcpip.h header check bug

[Diego Biurrun]

On Thu, Oct 27, 2011 at 05:52:46PM +0200, Ingo Brückl wrote:
> Diego Biurrun wrote:
> 
> > Supporting old Cygwin releases is not worth maintaining hacks.
> 
> This release isn't old, but the latest release running on Windows 95/98/Me.

Those OSes are nothing we need to worry about.  In this day and age, XP
is a sensible baseline.

> Calling the patch a hack is disrespectful and a very strange point of view.

Sorry, but a hack is a hack and we have been calling each other's hacks
hacks since forever.  If you have a problem with that you wil be in for
a hard time, so please grow a thicker skin.  Just to make it clear: What
I said above applies to me as well.  Many of my hacks have been called
that and rejected over the years.

> > Anyway, this is a non-issue that is not worth extra code until a real
> > problem is presented.
> 
> I did so, but you decided to discount it.

No, I did not discount it.  You call a redundant check a bug, which it
is not.  An incorrect detection result would be a bug; an extra check
is a performance problem at best.

> So I assume you're going to donate a non-outdated version of Windows and
> a non-outdated hardware to run that to me in order to assist my Win32 GUI
> developing efforts?

https://www.virtualbox.org/

Diego