[MPlayer-dev-eng] [MPlayer-cvslog] r34099 - in trunk/libass: ass.c ass.h ass_bitmap.c ass_bitmap.h ass_cache.c ass_cache.h ass_drawing.c ass_font.c ass_font.h ass_fontconfig.c ass_fontconfig.h ass_library.c ass_library.h ass_parse.c...

[Erik Auerswald]

Hi,

On Tue, Sep 13, 2011 at 04:31:27PM +0200, Erik Auerswald wrote:
> On Tue, Sep 13, 2011 at 03:58:56PM +0200, Diego Biurrun wrote:
> > On Tue, Sep 13, 2011 at 02:39:19PM +0200, Erik Auerswald wrote:
> > > On Tue, Sep 13, 2011 at 01:51:45PM +0200, Diego Biurrun wrote:
> > > > On Tue, Sep 13, 2011 at 09:09:49AM +0200, Erik Auerswald wrote:
> > > > > 
> > > > > On Mon, Sep 12, 2011 at 06:12:41PM +0200, Reimar Döffinger wrote:
> > > > > > [...]
> > > > > > If we want to remove things: Does anyone remember a reason to keep
> > > > > > mp3lib? Because that one is high-cost in comparison.
> > > > > 
> > > > > I currently need mp3lib because the default mpg123 crashes on every mp3
> > > > > file I have.
> > > > 
> > > > What do you mean by "default mpg123"?
> > > 
> > > That MPlayer decides to use the mpg123 (based?) code by default.
> > 
> > I'm still not following.  Is "default mpg123"
> > 
> > a) what MPlayer carries along in the mp3lib/ directory or
> > b) the upstream libmpg123 from mpg123.de (which version)?

My MPlayer is linked against the system's libmpg123 (version libmpg123-0
(= 1.12.1-3.2) packaged by Debian).

The mp3lib code comes from the MPLayer repo (included version).

The latter works for me, the former does not.

I know that this is no proper bug report (which would be off topic
anyway ;), I just argue for keeping mp3lib/.

Thanks,
Erik
-- 
Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it.
                        -- Brian W. Kernighan