[MPlayer-dev-eng] [PATCH] Doxygen and conditional compilation

[Ingo Brückl]

Diego Biurrun wrote on Mon, 19 Sep 2011 11:57:20 +0200:

> I must say this has a smell of workaround to it.

If it's OK to make conditional definitions (to remove otherwise useless
code), I can't understand why everyone is saying this.

> What problem are you trying to fix exactly?

See gui/interface.h line 105 or gui/ui/gtk/menu.c, line 383 or mplayer.c,
line 542, for example. Shouldn't these show up in a (complete) MPlayer
documentation (i.e. shouldn't all the CONFIGs be set for a complete
documentation)?

>> -EXPAND_ONLY_PREDEF     = NO
>> +EXPAND_ONLY_PREDEF     = YES

> What about setting MACRO_EXPANSION to "yes" instead?

This doesn't help if a macro isn't defined at all.

MACRO_EXPANSION is a complete different matter and affects code like
libvo/vo_x11.c, line 67. (It may be a good idea to set it, too, though.)

Ingo