[MPlayer-dev-eng] [PATCH] remove mp3lib

[Ivan Kalvachev]

On 9/23/11, Diego Biurrun <diego at biurrun.de> wrote:
> On Fri, Sep 23, 2011 at 08:28:32AM +0200, Thomas Orgis wrote:
>> Am Fri, 23 Sep 2011 03:45:49 +0300
>> schrieb Ivan Kalvachev <ikalvachev at gmail.com>:
>>
>> > Even if we assume the extra 6 seconds are because of the ugly float
>> > conversion and clipping i've done in af_format, even then mp3lib is
>> > still around 16% faster than the float only case.
>>
>> Would you care to give the ac mpg123 a spin, too? Regardless about the
>> performance of ffmpeg's mp3 (and mp2, and mp1) decoding, the comparison
>> to the official mpg123 code should work out on removing the internal
>> fork.
>>
>> Because of improved SSE code, mpg123 should be faster on platforms
>> supporting that. The game is not that clear for MMX and 3DNow*, where
>> subtle effects of the libmpg123 binding could rule.
>>
>> Make sure to use mpg123 version 1.13.x, please (there was some
>> optimization regarding the data transfer from MPlayer).
>
> I was about to step in and say something like this :)
>
> The interesting case is comparing internal vs. external mp3lib/mpeg123,
> not so much ffmp3 or ffmp3float.

Would you please do a full benchmark suit and post it here. If I
remember correctly you had some flavor of K6. It would be good to have
all benchmarks in single thread.