[MPlayer-dev-eng] [RFC PATCH] Default to subtitle visibility off (was Re: Question for dev's: Does mplayer disable DPMS timeouts? "xset q" looks good, but timeouts never trigger)

[Reimar Döffinger]

On Mon, Sep 26, 2011 at 12:13:56AM +0200, Erik Auerswald wrote:
> Ping again,
> 
> On 09/18/2011 02:51 PM, Erik Auerswald wrote:
> >no comments regarding the small patch that hides subtitles unless the
> >subtitle selection code actually selects a subtitle stream?
> >
> >On 09/09/2011 09:54 PM, Erik Auerswald wrote:
> >>[...]
> >>The attached patch (actually tested) is a definite improvement for me.
> >>When specifying -slang XX or having a suitably named .srt file lying
> >>near a movie, subtitles are displayed. But the mere presence of
> >>subtitles on a DVD does not result in displaying them automatically.
> >>
> >>Please consider applying.
> >
> >The patch still applies cleanly.
> 
> It still does.
> 
> The change in behavior is practically just hiding subtitles on DVD
> unless a subtitle language is specified. In all other cases (MPlayer
> finds some subtitles, e.g. because of command line or file name)
> they are still displayed.
> 
> ACK/NAK/Timeout?

I am not sure what exactly sub_visibility does, but it does not cause
the same behaviour as using -nosub or similar so I am rather sceptical
to it. In particular I think it causes the subtitle to be demuxed, which
in some cases (which you could cause bugs) has a chance of causing
playback issues over slow/non-seekable connections like a stream or
http.