[MPlayer-dev-eng] [patch] check pkg-config first for libdvd{nav, read}
Diego Biurrun
diego at biurrun.de
Sat Apr 7 11:01:38 CEST 2012
On Fri, Mar 30, 2012 at 02:18:04PM -0400, Mike Frysinger wrote:
> managing pkg-config files is a lot easier when cross-compiling then a variety of
> config scripts. the libdvd{nav,read} packages install .pc files now, so check
> those first before falling back to the config scripts.
>
> (please cc me as i'm not on the list)
>
> --- configure (revision 34835)
> +++ configure (working copy)
> @@ -4042,7 +4042,7 @@ echores "$_apple_ir"
>
> echocheck "pkg-config"
> -_pkg_config=pkg-config
> +_pkg_config=${PKG_CONFIG:-pkg-config}
That doesn't quite fit the patch description.
> @@ -7721,13 +7726,20 @@ if test "$_dvdnav" = auto ; then
> dvdnav_internal=yes
> res_comment="internal"
> else
> - $_dvdnavconfig --version --minilibs >> $TMPLOG 2>&1 || _dvdnav=no
> + if ! $_pkg_config --exists dvdnavmini ; then
> + $_dvdnavconfig --version --minilibs >> $TMPLOG 2>&1 || _dvdnav=no
> + fi
> fi
> fi
I wonder why you do not test pkg-config, but only dvdnav-config here.
Diego
More information about the MPlayer-dev-eng
mailing list