[MPlayer-dev-eng] Reverted patch of time-based PTS locking

[Reimar Döffinger]

On 18 Aug 2012, at 13:21, Pásztor Szilárd <don at tricon.hu> wrote:
> Reimar Döffinger:
>> I don't have time to do much programming myself, but it's enough to
>> answer questions and give hints.
> 
> Then I'll try to make use of that :)
> I'm looking around in ffmpeg, following your advice, to get libavcodec reorder
> the PTS coming from H264 streams. It works nicely in ffplay, however ffplay
> does a lot of packet queuing and similar stuff before feeding data to the
> decoder. The decoder does a good job in reordering and guessing pts, but it
> needs the packet pts as input. In mplayer, vd_ffmpeg.c does not feed the
> packet pts into the decoder, only NOPTS_VALUE, so this feature cannot work in
> libavcodec. Do you maybe know if there is a specific reason for not feeding
> this pts? I'm currently trying to figure out how it could be done if there is
> no objection.

I wouldn't be surprised if some issues came up (MPlayer packet queues are not well tested to keep the pts with the right packet, particularly in combination with native demuxers).
However the only reason currently is
1) nobody took the time to implement it properly
2) changing that won't fix things when e.g. using a binary codec to decode

Note: 2) is not a big issue in my opinion, though I don't want non-FFmpeg codecs broken more than now.