[MPlayer-dev-eng] [PATCH] lavcac3enc: make the filter buildable with shared FFmpeg

[Ivan Kalvachev]

On 1/30/12, Anssi Hannula <anssi.hannula at iki.fi> wrote:
> Add some local definitions and a bit rate array to make FFmpeg private
> headers and symbols unneeded, allowing lavcac3enc to be built with
> shared FFmpeg.
>
> This also fixes the issue that the filter code expects the FFmpeg
> private definition AC3_MAX_CHANNELS to be the maximum number of
> "logical" channels to be encoded into AC-3, while it actually specifies
> the maximum channel count in the bitstream, which may include a coupling
> channel which is not an actual full audio channel. The issue is fixed by
> making the local AC3_MAX_CHANNELS to have the value of 6, which the
> FFmpeg private header also had before the addition of coupling support
> in 2011.
> ---
>
> Dunno if this is something that is wanted or not, but in case of NAK the
> different expectation of AC3_MAX_CHANNELS should be fixed in some other
> way (e.g. by introducing a new local #define).

I would like to ask you of two things. Please resend your patch as
attachment, unlike linux kernel we prefer to have it easy.

Also, you may try to use FF_ARRAY_ELEMS() to count the number of
elements in a array, instead of the other way around.
It is not a show stopper demand, it seems that it is not used in the
corresponding  ac3enc.c code.


I would like to ping our configure master to comment on that portion
or he shell not complain when this patch is committed.