[MPlayer-dev-eng] [PATCH] Fix compiling with osdep setenv

Alexander Strasser eclipse7 at gmx.net
Thu Feb 16 02:08:32 CET 2012


Hi,

  on #mplayer IRC channel redxii reported the problem that
when compiling on MinGW.

  The patch is not yet really tested and therefore might contain
stupid errors. Would be nice if someone could help out. I try to
test it more thoroughly but I am not sure when I will get around
to it.

  Anyway I think the idea of the patch is easily understandable.
IIRC back in the day we did not add a prototype for osdep setenv
implementation because it was argued that it matches the default
C function signature (return int and take any arguments).

  But nowadays we have -Werror-implicit-function-declaration in
CFLAGS and therefore the osdep setenv replacement will be build
on platforms missing it but the compilation will fail when
attempting to compile the C files that use it and therefore
never reach linking stage.

  Alexander
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-fix_compiling_with_osdep_setenv.diff
Type: text/x-diff
Size: 2459 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20120216/a2ac78a2/attachment.bin>


More information about the MPlayer-dev-eng mailing list