[MPlayer-dev-eng] [PATCH] update ad_mpg123 in preparation to replace mp3lib

[Diego Biurrun]

On Wed, Feb 29, 2012 at 01:57:54PM +0100, Thomas Orgis wrote:
> 
> Anyhow, here is my updated patch to get the most out of upcoming
> mpg123 1.14.0 (the 1.14-beta1 just being released) with MPlayer and
> also to play safe with older releases. On x86-64, also the old mpg123
> brings performance benefits.
> 
> Test, discuss, and hopefully apply;-)

Good work, I'm glad to see all that ugly ifdeffery go.  What's the
minimum library version you are requiring now?

> --- libmpcodecs/ad_mpg123.c	(Revision 34780)
> +++ libmpcodecs/ad_mpg123.c	(Arbeitskopie)
> @@ -353,16 +274,45 @@
>  
> +            if(ret == MPG123_ERR)

if (, more below

> @@ -443,7 +386,11 @@
> +#ifdef AD_MPG123_MEAN_BITRATE
> +        con->delay = 1;
> +        con->mean_rate = 0.;
> +        con->mean_count = 0;

align the =

> @@ -477,6 +424,12 @@
>          }
> +#ifdef AD_MPG123_FRAMEWISE
> +        /* Going to decode directly to MPlayer's memory. It is important
> +         * to have MPG123_AUTO_RESAMPLE disabled for the buffer size
> +         * being an all-time limit. */
> +        sh->audio_out_minsize = 1152*2*sh->samplesize;

spaces around *

Diego