[MPlayer-dev-eng] [PATCH] libmpdemux/demux_audio: Skip ID3v2.4 tags.

[Ingo Brückl]

Reimar Döffinger wrote on Tue, 17 Jan 2012 19:23:48 +0100:

> On Tue, Jan 17, 2012 at 03:04:21PM +0100, Benoît Thébaudeau wrote:

> Seems fine to me.
> Anyone volunteering to do a final test and apply?
> I prefer to leave the work to others, but if not I'll apply it
> after waiting for comments a tiny bit longer.

I personally would only perform a footer flag check and accept the 3DI footer
if version is 4 or above.

AFAIK valid ID3v2 tag headers start with version 2, so we should not drop
this check.

You already mentioned that ("very, very unlikely to matter") in case len is 0
(error or malformed tag), the stream position may be somewhere between ID3v2
flags and ID3v2 size, but we step 4.

If len > demuxer->movi_end - demuxer->movi_start, it cannot be decided
whether this is a malformed footer or just audio data. There should be
neither an error message nor a len setting in this case. (Same, if the
corresponding and valid ID3 header cannot be found.)

Error (wouldn't warning or hint have been sufficient here?) messages, if any,
should be translatable.

I'm not sure whether it is worth the effort to check the whole 3DI footer
data against the ID3 header data. According to the specs they must be copies.

BTW, after applying I would change stream_seek(s,s->end_pos-128) to
stream_seek(s,demuxer->movi_end-128) to avoid problems if the sequence of
checks ever changes or a new check will be prepended.

Just my two cents.

Ingo