[MPlayer-dev-eng] GUI fails with skin PNG read error

[Paul B Mahol]

On 1/26/12, compn <tempn at twmi.rr.com> wrote:
> On Thu, 26 Jan 2012 17:35:59 +0000, Paul B Mahol wrote:
>>On 1/26/12, Ingo Brueckl <ib at wupperonline.de> wrote:
>>> In mplayer-users there are reports that skin loading fails.
>>>
>>> And indeed, after I've updated ffmpeg today, I'm experiencing the same
>>> error.
>>>
>>> I tracked it down to Carl Eugen Hoyos' "Simplify 32bit png decoding"
>>> patch
>>> of
>>> libavcodec/pngdec.c.
>>>
>>> So far, the call to avcodec_decode_video2() in gui/util/bitmap.c returned
>>> PIX_FMT_BGRA which seems to be the right one:
>>>
>>>   $ ffprobe /usr/share/mplayer/skins/Clearlooks/main.png
>>>   [...]
>>>   Input #0, image2, from '/usr/share/mplayer/skins/Clearlooks/main.png':
>>>     Duration: 00:00:00.04, start: 0.000000, bitrate: N/A
>>>       Stream #0:0: Video: png, bgra, 340x120, 25 tbr, 25 tbn, 25 tbc
>>>                                ^^^^
>>> Now it suddenly returns PIX_FMT_RGBA which isn't handled in the GUI.
>>>
>>> Carl Eugen, what's going wrong?
>>
>>Png decoder no longer does transcoding ... :)
>>
>>Gui code is broken.
>
> so you'd have to add the little bit of code to the gui, to swap the
> bytes to get bgra from rgba ?

adding case for PIX_FMT_RGBA does not work?