[MPlayer-dev-eng] [PATCH] GUI: Fix blocking after end of file when trying to play file/stream/playl

Hans-Dieter Kosch hdkosch at kabelbw.de
Sun Nov 25 23:55:29 CET 2012


Ingo Brückl wrote:
> 
> Track number and playlist editing I know (there are a few bugs on my list),
> but video size?
> 
Show size of mplayer idle image upon startup instead of 0x0, reset to 0x0 when 
video window is hidden (eg. playing CD)... Look forward to my next post, 
probably tomorrow, it also addresses track number.
> 
> STREAMTYPE_PLAYLIST is just an intermediate type to communicate with MPlayer
> 
I suspected this, I've read the comment in the header file, but I was not sure
(sometimes, comments are not up to date).
> 
>> +                !listMgr(PLAYLIST_GET, 0)) {
> 
> CURR is better.
> 
Hmm, why (the aim is to see if a playlist exists at all)?
> 
> guiInfo.Filename is a strdup'ed value and must be freed.
> 
Tricky, there I would have been creating a memleak!

>> -            guiInfo.Track   = 1;
>> +            guiInfo.Track   = (guiInfo.StreamType == STREAMTYPE_DUMMY) ? 0 : 1;
> 
> Let's postpone this until we fix the track issues.
> 
OK.

> I hope I've fixed it in r35475.
> 
I've updated my working copy and will play with it.
BTW.: Your change to gui/ui/gtk/playlist.c in r35475 is exactly that what I've 
been looking for :-)


Hans-Dieter


More information about the MPlayer-dev-eng mailing list