[MPlayer-dev-eng] [FFmpeg-devel] [PATCH] FFmpeg: libavfilter/libmpcodecs: add vf_stereo3d high quality green-magenta and yellow-blue dubois anaglyph 3D output support

[thomas schorpp]

On 31.01.2013 21:37, Reimar Döffinger wrote:
> Hello,
> Thanks for the patch, just one minor comment for the future:
>
> On Thu, Jan 31, 2013 at 12:52:22PM +0100, thomas schorpp wrote:
>> -        case ANAGLYPH_YB_COLOR: {
>> +        case ANAGLYPH_YB_COLOR:
>> +        case ANAGLYPH_YB_DUBOIS: {
>
> This part is really a bugfix, whereas the rest is a new feature.
> You should try to always split these into separate patches.
> This has several advantages, among them making it easier for
> people to notice that something was fixed and they maybe should
> try again if they noticed it not working before, and also
> would make it easier to maintain a stable version that only
> gets bugfixes but no new features - in case someone ever wants
> to do that.

Well, I considered it as incomplete feature or author's patch mismatch, not as a BUG but Thanks,
it's on the patch checklist from now on.

>
> Just repeating to be clear: nothing to do for you for this patch since it's
> already committed, just in case you should have more patches
> somewhen.

Well, maybe parallax adjustment option and more 3D storage format inputs from Bino, but maybe I
port the filter to gstreamer, if it performes better with crystalhd on transcoding but that's not the
case yet, it just crashed the Broadcom driver again on the first attempt using transmageddon:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=699470

y
tom