[MPlayer-dev-eng] [PATCH] Check for windows.h
Josh Finch
joshf87 at live.com
Tue Jan 8 18:01:55 CET 2013
Checking for the headers doesnt have to be in the "if mingw32" statement, just end the if statement after checking for w32threads.
> Date: Tue, 8 Jan 2013 17:45:51 +0100
> From: auerswal at unix-ag.uni-kl.de
> To: mplayer-dev-eng at mplayerhq.hu
> Subject: Re: [MPlayer-dev-eng] [PATCH] Check for windows.h
>
> Hi Josh,
>
> On 01/08/2013 05:30 PM, Josh wrote:
> > On 1/8/2013 06:55, Erik Auerswald wrote:
> >> def_windows_h='#define HAVE_WINDOWS_H 0'
> >
> > The follow would fall more in line with the rest of the configure script.
> > [...patch keeping the check inside if win32...]
>
> But that would not fix the warning for non-Windows systems.
>
> libavutil/time.c:32:5: warning: "HAVE_WINDOWS_H" is not defined [-Wundef]
>
> The one file using the define checks unconditionally #if HAVE_WINDOWS_H
> and as such I very much prefer to always have this define.
>
> The method used in my patch is used for thread support checking already
> (define every variable to 0, let Windows and OS/2 check change the value
> from 0 to 1 if applicable). Just look a bit further up in the file. ;-)
>
> Thanks,
> Erik
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
More information about the MPlayer-dev-eng
mailing list