[MPlayer-dev-eng] [PATCH] GUI: 'evPlay' with Playlist
Hans-Dieter Kosch
hdkosch at kabelbw.de
Fri Jan 25 01:54:25 CET 2013
Ingo Brückl wrote:
> Hans-Dieter Kosch wrote on Sat, 19 Jan 2013 01:57:13 +0100:
>
>> This regards selecting "Play" from the menu.
>
> If I only had pay attention to this information.
No problem (I see, you're very busy with WM code review).
> I desperately tried to find this bug with the skin I'm using and the Blue
> reference skin which both only have play-to-pause buttons. :-O
It's not depending on a skin. It happens when selecting the action from the GUI
menu (right mouse click over the video window).
> Anyway, I can confirm this bug but would like to fix it differently, because
> we don't need the same condition for all the cases - and there's code that
> could be dropped.
I noticed that redundant code too.
> Does the attached patch work for you?
Works fine :-)
And there could be more code compacted:
"
case STREAMTYPE_CDDA:
case STREAMTYPE_VCD:
case STREAMTYPE_DVD:
if ( !guiInfo.Track )
guiInfo.Track=(guiInfo.StreamType==STREAMTYPE_VCD)?2:1;
guiInfo.NewPlay=GUI_FILE_SAME;
break;
"
(Not sure how to write correctly in that strange coding style).
Thanks for your attention,
Hans-Dieter
More information about the MPlayer-dev-eng
mailing list