[MPlayer-dev-eng] [PATCH] Don't destroy a -wid window's WM_NORMAL_HINTS property information

[Ingo Brückl]

Reimar Döffinger wrote on Sun, 27 Jan 2013 15:41:48 +0100:

> On 22 Jan 2013, at 14:29, Ingo Brückl <ib at wupperonline.de> wrote:

>> I noticed that the GUI's video window loses its aspect property after being
>> iconized and tracked down the bug to the vo driver. We can either prevent
>> the destruction itself (x11_common.patch) or copy the information prior to
>> its - pointless - usage (x11_common.alternative.patch).
>>
>> Which one shall I apply?

> I think the first one, vos should never change properties of windows it
> got passed via WinID unless absolutely necessary.

I agree (although the second one - without the pointless XSetWMNormalHints -
might be worth applying in addition, just in case the vo driver will need to
access the XSizeHints of the window - which it currently doesn't do though).

Applied.

Ingo