[MPlayer-dev-eng] [PATCH] GUI: Activate potmeter

[Ingo Brückl]

Hans-Dieter Kosch wrote on Wed, 19 Feb 2014 00:36:59 +0100:

> Ingo Brückl wrote:
>> Hans-Dieter Kosch wrote on Sun, 16 Feb 2014 23:04:35 +0100:
>>
>>> The 'pressed' state of a 'potmeter' item is not initialised.
>>
>> Agreed.
>>
>>> By default it's 0 ('btnDisabled'), and the item is inactive.
>>
>> A potmeter doesn't have a btnDisabled state. Actually,
>> the pressed state of a potmeter is irrelevant, because
>> they cannot be pressed.
>>
> Cf. gui/skin/skin.c: line 619: in function item_hpotmeter():
>      item->pressed   = btnReleased;

I know, but you can't compare to a hpotmeter. A hpotmeter has a button, a
potmeter doesn't.

> The 'item->pressed' is used in gui/ui/main.c, line 102:
>      if ( ( guiApp.mainItems[i].pressed != btnDisabled )&&
> to determine if an object under the mouse is enabled. If it's
> 'btnDisabled', then the object is ignored and the window is moved instead
> of shifting the pot when the mouse is pressed and dragged.

Ok. So you want a potmeter to be shiftable by the mouse?

Did you notice that you already can do so with the Blue skin you were
referring to while a video is playing? (So where do you miss mouse
shiftability?)

(Admittedly, not all potmeters act this way. Would it be an alternative
solution to adjust their behaviour to a movie position potmeter?)

Please keep in mind that (currently) potmeters aren't designed for user
action. (Don't blame me, I did not invent them.)

Ingo