[MPlayer-dev-eng] [PATCH] mencoder: support cinepak encoding via -ovc lavc

[Reimar Döffinger]

On 27.01.2014, at 16:08, u-2w2r at aetey.se wrote:
> On Mon, Jan 27, 2014 at 09:24:29AM -0500, compn wrote:
>>> --- libmpcodecs/ve_lavc.c.ori   2014-01-25 22:47:58.861287479 +0100
>>> +++ libmpcodecs/ve_lavc.c       2014-01-26 19:42:50.891709449 +0100
>>> @@ -975,6 +977,8 @@
>>>        mux_v->bih->biCompression = mmioFOURCC('d', 'r', 'a', 'c');
>>>     else if (!strcasecmp(lavc_param_vcodec, "libvpx"))
>>>        mux_v->bih->biCompression = mmioFOURCC('V', 'P', '8', '0');
>>> +    else if (!strcasecmp(lavc_param_vcodec, "cinepak"))
>>> +       mux_v->bih->biCompression = mmioFOURCC('c', 'v', 'i', 'd');
>>>     else
>>>        mux_v->bih->biCompression = mmioFOURCC(lavc_param_vcodec[0],
>>>                lavc_param_vcodec[1], lavc_param_vcodec[2],
>>> lavc_param_vcodec[3]); /* FIXME!!! */ --- DOCS/man/en/mplayer.1.ori
>>> 2014-01-26 20:39:51.215795665 +0100 +++ DOCS/man/en/mplayer.1
>>> 2014-01-26 20:40:28.596233764 +0100 @@ -9647,6 +9647,8 @@
>>> for lossless JPEG, ffv1 and svq1
>>> .IPs "BGR32"
>>> for lossless JPEG and ffv1
>>> +.IPs "RGB24"
>>> +for cinepak
>>> .RE
>>> .PD 1
>> 
>> 
>> is CVID or cvid preferred by binary codecs?
> 
> I see lowercase "cvid" in all of the ancient cinepak samples which I checked
> (a random handful from http://samples.mplayerhq.hu/V-codecs/CVID).
> 
> Thus I assume lowercase is historically "the norm" or at least "good enough".

Only slightly related: in principle it would be much nicer if we would get the fourcc through lookup in one of the standard tables we already have instead of having to manually add it here...