[MPlayer-dev-eng] [PATCH] Add support for default of multiple video tracks

[Reimar Döffinger]

On 27.01.2014, at 21:55, Ingo Brückl <ib at wupperonline.de> wrote:
> I wrote on Mon, 27 Jan 2014 19:20:07 +0100:
> 
>> Index: mplayer.c
>> ===================================================================
>> +++ mplayer.c   (working copy)
>> @@ -3458,6 +3458,13 @@
>>         int tmp = ts_prog;
>>         mp_property_do("switch_program", M_PROPERTY_SET, &tmp, mpctx);
>>     }
>> +
>> +    // select video stream
>> +    if (video_id == -1) {
>> +        int tmp = demuxer_default_video_track(mpctx->demuxer);
>> +        mp_property_do("switch_video", M_PROPERTY_SET, &tmp, mpctx);
>> +    }
>> +
>>     // select audio stream
>>     select_audio(mpctx->demuxer, audio_id, audio_lang);
>> 
> 
> This can be done much better.
> 
> The mplayer.c part of the patch attached to this posting doesn't change
> video_id which is preferable.

This doesn't seem right/make sense to me.
The stream selection code if I remember right is in the code that adds a new stream.
The reason for that is that it can also handle new streams appearing that you might not know about yet in that part of mplayer.c for example.