[MPlayer-dev-eng] [patch] gui ignores mplayer volume option

[Stephen Sheldon]

On 7/29/2014 3:34 PM, Ingo Brückl wrote:
> I wrote on Tue, 29 Jul 2014 23:56:55 +0200:
>
>> In the meantime, I have a working solution for assigning the skin defaults
>> [...], but it seems that there are some bugs with setting volume and/or
>> balance (evSetVolume, evSetBalance, GUI_SET_VOLUME_BALANCE) in the Win32
>> GUI (with dsound, at least).
> BTW, this is what I have so far.
>
> Ingo
This works for me, on ming64, including set movie position.  Thank you.

The code for evSetVolume looks  buggy, like it is missing an else:

             if (guiInfo.Balance == 50.0f)
                 mixer_setvolume(mixer, guiInfo.Volume, guiInfo.Volume);
ELSE here ?
             l = guiInfo.Volume * (100.0 - guiInfo.Balance) / 50.0;
             r = guiInfo.Volume * guiInfo.Balance / 50.0;