[MPlayer-dev-eng] [PATCH] vo gl: Output complete suboption help
Roberto Togni
rxt at rtogni.it
Mon Nov 30 21:57:33 CET 2015
On Mon, 30 Nov 2015 18:45:02 +0100
Alexander Strasser <eclipse7 at gmx.net> wrote:
> The output is incomplete because of the buffer in mp_msg
> implementation being smaller than the help output.
>
> Fixing it by increasing the maximal message length in
> mp_msg.c seems not wise, as usually 2 buffers of that
> length are allocated on the stack.
>
> So just print help with 2 mp_msg calls.
>
> Signed-off-by: Alexander Strasser <eclipse7 at gmx.net>
> ---
> libvo/vo_gl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libvo/vo_gl.c b/libvo/vo_gl.c
> index b42b5d9..0ac33ac 100644
> --- a/libvo/vo_gl.c
> +++ b/libvo/vo_gl.c
> @@ -1334,7 +1334,8 @@ static int preinit_internal(const char *arg, int allow_sw)
> " customtrect\n"
> " use texture_rectangle for customtex texture\n"
> " mipmapgen\n"
> - " generate mipmaps for the video image (use with TXB in customprog)\n"
> + " generate mipmaps for the video image (use with TXB in customprog)\n" );
> + mp_msg(MSGT_VO, MSGL_FATAL,
> " osdcolor=<0xAARRGGBB>\n"
> " use the given color for the OSD\n"
> " stereo=<n> (add 32 to swap left and right)\n"
No objections from me
Ciao,
Roberto
More information about the MPlayer-dev-eng
mailing list