[MPlayer-dev-eng] [PATCH] haiku support

[Alexander Strasser]

Hi all!

On 2017-09-10 15:57 +0200, Reimar Döffinger wrote:
> On 08.09.2017, at 08:10, Reimar Döffinger <Reimar.Doeffinger at gmx.de> wrote:
> 
> > On 02.09.2017, at 22:28, Compn <tempn at mi.rr.com> wrote:
> > 
> >> patch looks ok to me.

I am not against this if it passes review. Of course license problems
will have to be resolved first.

Both will probably be hard if the original author is not available.

> >> maintained by miqlas.

Is miqlas possibly subscribed here?
Would miqlas be willing to maintain these modules in MPlayer?

Best regards,
  Alexander

> >> any haiku users out there? :)
> > 
> > Some of the files lack license headers, I don't think the ao/vo modules should be enabled unconditionally,
> > the libraries should be linked against depending on enabed modules, not depending on OS,
> > the header include guards don't have the right format (especially should not start with _),
> > several files miss license headers (and I don't like the MIT license one either, because then I have to check of it's compatible with GPL, plus the actual license needs to be included as well).
> 
> I now checked, unfortunately the are quite a few "MIT" licenses, and some few of those are actually GPL-incompatible (contain advertising clause).
> So I'm afraid the licensing needs to be clarified before we can add it, otherwise distributions like Debian will be mad at us...