[MPlayer-dev-eng] [PATCH 1/2] Remove direct uses of __attribute__((packed)).

Reimar Döffinger Reimar.Doeffinger at gmx.de
Mon Jan 25 20:57:23 EET 2021


On Mon, Jan 25, 2021 at 08:04:36PM +0900, KO Myung-Hun wrote:
> > -typedef struct __attribute__((__packed__)) RECT32
> > +MP_PACKED(
> > +typedef struct, RECT32
> >  {
> >      int left, top, right, bottom;
> >  } RECT32;
> > +)
>
> In file included from loader/dshow/iunk.h:9,
>                  from loader/dshow/interfaces.h:10,
>                  from loader/dshow/inputpin.h:4,
>                  from loader/dshow/DS_Filter.h:4,
>                  from loader/dshow/DS_AudioDecoder.c:11:
> loader/dshow/guids.h:34:1: error: macro "MP_PACKED" passed 5 arguments,
> but takes just 2
>    34 | )
>       | ^

Fixed.

> > @@ -132,6 +132,7 @@ static int read_toc(const char *dev)
> >  #elif defined(__OS2__)
> >      UCHAR auchParamDisk[4] = {'C', 'D', '0', '1'};
> >
> > +MP_PACKED(
>
> stream/stream_cddb.c: In function 'read_toc':
> stream/stream_cddb.c:135:1: error: implicit declaration of function
> 'MP_PACKED' [-Werror=implicit-function-declaration]
>   135 | MP_PACKED(

Sorry, I had missed that this was OS/2-specific code, it
should not have been changed.
Removed the stream_cddb.c changes.

Thanks for testing it!


More information about the MPlayer-dev-eng mailing list