[MPlayer-dev-eng] [PATCH] tests/faterun: Use single-threaded decoding for mov/empty_edit_5s.mp4

Alexander Strasser eclipse7 at gmx.net
Sun Mar 28 21:48:24 EEST 2021


This sample resulted in changing checksums when decoding with 4
threads. I couldn't find anything wrong about testing this sample
with valgrind, thus I concluded it is because of using multi-threaded
decoding when error concealing happens.
---
 tests/faterun.sh | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/tests/faterun.sh b/tests/faterun.sh
index 7df8ade67..acba45aa2 100755
--- a/tests/faterun.sh
+++ b/tests/faterun.sh
@@ -7,11 +7,17 @@ fi
 sample="$1"
 md5out="tests/res/$sample.md5"
 ref_file="tests/ref/$sample.md5"
-options="-noconfig all -lavdopts threads=4:bitexact:idct=2 -really-quiet -noconsolecontrols -nosound -benchmark"
+options="-noconfig all -really-quiet -noconsolecontrols -nosound -benchmark"
 if [ -z ${sample##h264-conformance/*} ] ; then
   # these files generally only work when a fps is given explicitly
   options="$options -fps 25"
 fi
+if [ -z ${sample##mov/empty_edit_5s.mp4} ] ; then
+  # these do error concealing and yield non-deterministic results with threads
+  options="$options -lavdopts threads=1:bitexact:idct=2"
+else
+  options="$options -lavdopts threads=4:bitexact:idct=2"
+fi
 echo "testing $sample"

 # create necessary files and run
--


More information about the MPlayer-dev-eng mailing list