[MPlayer-dev-eng] [PATCH] mplayer has broken Letterboxing with xv Video Output on i3wm

[Erik Auerswald]

Hi,

On 21.05.22 22:38, Reimar Döffinger wrote:
> 
>> On 6 May 2022, at 23:49, Tobias Girstmair <t-mplayer at girst.at> wrote:
>> Solution:
>>   Remove the `if ( vo_fs )` gate in `void vo_xv_draw_colorkey(...)` in
>>   libvo/x11_common.c:2361.
>>   Since this function assumed the window is screen sized, it now draws
>>   oversized boxes. I modified it to use window width/height instead, so
>>   it only draw the pixels needed.
> 
> FYI one important case that needs testing is that resizing works, smoothly and flicker-free.

I've just tested that: this works just fine with -vo xv.  It
actually works much better with -vo xv and this patch than
it does with -vo gl.  I do not see a difference between before
and after this patch regarding flickering when resizing.

I think this is fine.

> That has been the reason why in the past it was not fixed, breaking tiling window managers seemed preferable of breaking resizing with non-tiling window managers.

For what it's worth, resizing with -vo gl has lots of flicker.
Resizing with -vo xv does not have this flicker, neither with
nor without the patch.

Fixing -vo xv for tiling window managers and maximized windows
on GNOME looks like an improvement to me.

> I think the issue is that with PAspect you would still end up with window sizes a few pixels off.
> So you would end up drawing these borders even though the tiny bad lines are of no real consequence (and probably should be fixed by changing the size of the video that is drawn).
> And doing so, especially during a resize sequence results in really bad flickering.

I'm not sure what you mean with "bad" flickering.  But I am
quite sure that this patch does not introduce it.  At least
it did not do so for me on Ubuntu GNU/Linux with Intel
integrated grafics.

Thanks,
Erik