[MPlayer-dev-eng] [PATCH] WIP: RFC: XXX: Unbreak build with GCC 14

[Alexander Strasser]

Hi Ingo!

On 2024-04-16 09:29 +0200, Ingo Brückl wrote:
> On Mon, 15 Apr 2024 23:36:37 +0200, Alexander Strasser wrote:
>
> > 3. I might have touched some warnings by accident because we have
> >    so many of them accumulated and I might have forgotten to
> >    actually search to the next error :(
>
> Shouldn't we first get the Makefile to do a quiet build and fix all the
> accumulated warnings that are blowing up in our faces (see the thread on
> compiler warnings from February 2011) before we address GCC 14 warnings
> and errors?

Hmm. Yes and no :)

When talking about ordering I would say working with GCC 14 has a
higher priority then making the build quiet.

That is if you mean by implementing a quiet build, to make the actual
command lines be replaced by the shortened `  CC x.o` etc.

Regarding actually fixing the warnings, I agree it would be good
if they were fixed. OTOH actually fixing the warnings is no small
nor easy task and can't be planned to be started and finished in
a set time frame.

One last thing that maybe also supports my efforts of fixing those
GCC 14 errors addressed by my patch is that it pretty likely mostly
just fixes warnings that previously weren't errors. In other words
fixing the GCC 14 errors is fixing pre-GCC 14 warnings and thus
partially what you suggest :)


> > If we actually build with GCC 14 we could also look into current
> > clang. Didn't work for me when I tried...
>
> Should be easier then to fix that too.

Probably. In any way it's not really urgent I would say, but I
would consider getting and keeping at least GCC and Clang working
is a good minimal goal for supported compilers.


> Just my two cents.

Thanks for your feedback!


  Alexander