[MPlayer-DOCS] [PATCH] XviD documentation reaching almost completeness

[Guillaume POIRIER]

Le mar 07/09/2004 à 14:34, The Wanderer a écrit :
> Guillaume POIRIER wrote:
> 
> > Le mar 07/09/2004 à 12:08, The Wanderer a écrit :
> > 
> >> The difficulty appears to have been that we were talking about
> >> different sentences, and thus different problems. <grin> Rather
> >> explains the confusion... is it any clearer now?
> > 
> > Heck... I'm not even sure! Using compensate that way still seem
> > fairly unnatural to me.
> 
> Just consider it one of the quirks of the language; English has so many
> special cases and context-based exceptions, it's hardly even funny
> anymore.

Many thanks to the reviewers then... ;-) Lots of contributors, and few
English native speaker?


> > You'll get also on the patch the 3 little babies that were previously
> > marked "FIXME".
> 
> I missed noticing those...

... I meant: they were marked as FIXME in "*round-0 'till 4" version of
this patch. No biggie though!


> > I don't plan to commit this patch unless you give my your go-ahead as
> > these descriptions are new.
> 
> Well, I haven't gone through the patch itself in detail before (just
> what people have commented on), but I'll do that now. I'm not in
> high-nitpick mode, but there will probably be a few things...
> 
> > +.B bf_threshold=<-255\-255>
> > +Sometimes B frames do not look good, and introduce artifacts when most of
> > +the frame is static and some small zones have high motion (in a static
> > +scene with a man talking, his mouth will probably look bad if what is
> > +surrounding the man and his mouth is completly static).
> 
> Typo - that's "completely".
> 
> > +This setting allows you to favorize or not, the use of B frames.
> > +The higher the value, the higher the probability of B frames being used.
> > +(default: 0)
> 
> "Favorize" isn't a word, at least not in English. Going by what I think
> you mean, I'd suggest something like "This setting allows you to specify
> what priority to place on the use of B frames.".

I corrected it your way.


> Apropos of that last bit, in an earlier part of the patch you use
> "I-frames", but here and in at least one place below you use "B frames".
> I have no strong preference about whether or not to include the hyphen
> (both forms feel bad to me in different ways), but I would prefer for
> the usage to be consistent.

I hunted them down, and now it should be consistent.

> > +.B frame_drop_ratio=<0\-100>
> > +XviD keeps track of block coding type (skipped, predicted, intra).
> > +The skipped block counter can be used to choose whether a frame is so close
> > +to its reference that it can be
> 
> I don't think "choose" is the verb you want in this case... but I don't
> know what would be better. Diego? Any ideas?

I replaced it with "decide". I'm not sure if it makes a world of
difference though.



> > +The upper part of the curve is the set of values that are higher than
> > +the curve average.
> > +Think of that setting like a shrinking factor for the upper part of
> > +the curve (default: 0).
> 
> "the setting" in this case.

Do you mean I should write "Think of the setting like..."
... That's what I understood (but find it odd), and corrected.


> > +.B overflow_control_strength=<0\-100>
> > +During two pass, a scaled bitrate curve is computed.

It's now: "During pass 1 of 2-pass encoding, ..."


> There are many small things at which I could pick, but which I did not
> point out, because this has stretched out long enough already; if I
> decide that they really need to be corrected, I can go back and do it
> myself later on, and avoid arguing hyphenation six times as often as I
> need to.

Plus I had trouble keeping my patch "commit-able" against latest cvs, so
I'm looking forward this is over ;-)

Regards,

Guillaume

-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer1.0-20040906-en_man_xvid_1.0.x_options_round6.patch
Type: text/x-patch
Size: 10579 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-docs/attachments/20040907/2ab497c4/attachment.bin>