[MPlayer-DOCS] CVS: main/DOCS/man/en mplayer.1,1.746,1.747

[Diego Biurrun]

The Wanderer writes:
> Diego Biurrun CVS wrote:
> 
> > +.IPs lowres=<number>
> > +Decode at lower resolutions.
> > +Low resolution decoding is not supported by all codecs, and it will
> > +often result in ugly artifacts, this is not a bug, but a side effect
> > +of not decoding at the full resolution.
> 
> Period or semicolon after 'artifacts".

In my local tree.

> > +.B bmovl=hidden:opaque:fifo
> > +Reads bitmaps from a FIFO and displays them on top of the movie,
> > +allowing some transformations on the image.
> > +Also see TOOLS/bmovl-test.c for a small bmovl test program.
> 
> While this is not bad, with cryptically abbreviated option names my
> personal preference is for the option description to provide some
> indication of what they expand to. In this case, to the best of my
> knowledge it's "bitmap overlay"; either "overlays them on top of" or
> "displays them as overlays on top of" would serve the purpose, but both
> are more awkward than the current form.

Now it reads:

  The bitmap overlay filter reads bitmaps from a FIFO ..

> (Now that I've been reminded of this, I'll look through the man page
> later and see if I spot any other unexplained cryptic-abbreviation
> options. I'd do it now, but I have much else I want to do before leaving
> for work.)

Yes, they should definitely be explained.

> > @@ -4544,20 +4545,20 @@
> >  .IPs "ABGR32 width height xpos ypos alpha clear"
> >  followed by width*height*4 Bytes of raw ABGR32 data.
> >  .IPs "RGB24 width height xpos ypos alpha clear"
> > -followed by width*height*3 Bytes of raw RGB32 data.
> > +followed by width*height*3 Bytes of raw RGB24 data.
> >  .IPs "BGR24 width height xpos ypos alpha clear"
> > -followed by width*height*3 Bytes of raw BGR32 data.
> > +followed by width*height*3 Bytes of raw BGR24 data.
> >  .IPs "ALPHA width height xpos ypos alpha"
> 
> Is it appropriate to capitalize "Bytes" in these cases? I wouldn't have
> thought so, but I've been surprised by obscure or "me doesn't like this"
> usages before.

Bytes is another problem case, same as [Bb]its.  I'd say it should be
lowercase, nevertheless the capitalized variant is widespread.

> > @@ -4654,9 +4655,9 @@
> >  .PD 0
> >  .RSs
> >  .IPs x,y
> > -Position of the top left corner of the logo.
> > +logo top left corner position
> >  .IPs w,h
> > -Width and height of the cleared rectangle.
> > +cleared rectangle width and height
> 
> While the new form fits your capitalization rules, I would have thought
> that the previous form was more clear, at least in the first of these
> two cases. Now at first glance it just looks like a randomly assorted
> collection of adjectives and nouns.
> 
> I'd suggest returning to the previous forms and simply dropping the
> capitalization/periods (and possibly the first "of the" in the former of
> the two).

Yes, it's less clear, I've switched to

.IPs x,y
top left corner of the logo
.IPs w,h
width and height of the cleared rectangle

Diego