[MPlayer-DOCS] CVS: main/DOCS/xml/en mencoder.xml,1.39,1.40

[Diego Biurrun]

On Fri, Apr 01, 2005 at 09:53:10AM +0200, Guillaume Poirier wrote:
> 
> On Apr 1, 2005 1:39 AM, Diego Biurrun <diego at biurrun.de> wrote:
> > On Fri, Mar 25, 2005 at 10:17:23PM +0100, Guillaume Poirier CVS wrote:
> > >
> > > +  On the other hand, it's worthless to raise CQ as higher than 0.30 as you'd
> > 
> > s/as//
> 
> So that would be the correct form: 
> On the other hand, it's worthless to raise CQ higher than 0.30 as you'd

Yes.

> > > +  First of all, you will have to convert the DVD sound into a WAV file that the
> > 
> > Please try to keep lines below 80 characters, or even better 60-70
> > characters so that if small changes are made later on they show up
> > nicely in the diffs.
> 
> Ok. I guess that's a rule I should follow in the manpage too.

Yes.

> > > +  Please note that MEncoder currently can't currently mux Ogg Vorbis files
> > > +  into a video stream because it can only create AVI and MPEG files.
> > 
> > What are you trying to say here?  Either you have the distinction
> > between containers and formats wrong or you are just writing it in a
> > confusing fashion.  A video or audio stream can be muxed into a file,
> > but not vice versa.
> 
> Yes, that's unclear. I think I understand quite well the distinction
> between a container and a format.

The distinction is between a container and a _codec_.  Please don't use
the word format, it's overloaded.

> What I'm trying to say here is that ".avi" as well as ".mpg" files
> can't contain a Vorbis audio track.

OK.

> Would it be clearer if I had written:
> Please note that MEncoder currently can't currently mux Ogg Vorbis files
> into a video stream because it only supports AVI and MPEG containers.

No, not at all.  Again, don't confuse Ogg with Vorbis in the docs or the
distinction will never become clear.  You can mux different video and
audio streams into a container, but not a container into another (in
theory you can, but this is a VERY bad idea).  Thus you cannot mux Ogg
(a container) into AVI or MPEG (other containers).  It _is_ possible to
put Vorbis audio into AVI, but IIRC MEncoder does not support it out of
the box and IIRC AVI does not handle VBR audio well.  The sentence does
not make sense, please replace it completely.

> There's one thing you did not comment on: the arithmetic expressions I
> added don't have any a specific tag that could make them "shine out",
> if I may say so.
> For instance, the expression: ARc = (Wc x (ARa / PRdvd )) / Hc seems
> to me "drowned" in the rest of the paragraph, when I think it would be
> good if they would have their own style, just like LaTeX does.
> I haven't found any existing tag for arithmetic expression on the XML
> docs (maybe I did not dig deep enough), that's why I left it that way
> for now. What do you think about it?

The DocBook book mentions Equation, InformalEquation and InlineEquation.

> Other than that, I'm interested in any other nits you may have, given
> that I have no experience with XML.

It was fine overall.

Diego