[MPlayer-users] [BUG] [CVS] [Patch] --enable-xv is broken

[Andreas Metzler]

Hello!
If I use ./configure --enable-xv it won't enable Xv, if I simply use
./configure it will.

*/tmp/MPlayer-20011121>*  ./configure --enable-xv 2>&1 | grep -1i xv
Checking for DPMS ... using xdpms4
Checking for Xv ... no
Checking for Xinerama ... yes

Corresponding lines in configure.log:
| ============ Checking for Xv ============
| Result is: no
| ##########################################

*/tmp/MPlayer-20011121>*  ./configure  2>&1 | grep -1i xv
Checking for DPMS ... using xdpms4
Checking for Xv ... yes
Checking for Xinerama ... yes

Corresponding lines in configure.log:
| ============ Checking for Xv ============
| 
| #include <X11/Xlib.h>
| #include <X11/extensions/Xvlib.h>
| int main(void) { (void) XvGetPortAttribute(0, 0, 0, 0); return 0; }
| 
| gcc    /tmp/mplayer-conf-19344-14446.c -o /tmp/mplayer-conf-9179-14446.o -L/usr/X11R6/lib -lX11
| -lXext -lnsl -lXv
| 
| ldd /tmp/mplayer-conf-9179-14446.o
|         libX11.so.6 => /usr/X11R6/lib/libX11.so.6 (0x4001f000)
|         libXext.so.6 => /usr/X11R6/lib/libXext.so.6 (0x400fa000)
|         libnsl.so.1 => /lib/libnsl.so.1 (0x40108000)
|         libc.so.6 => /lib/libc.so.6 (0x4011e000)
|         /lib/ld-linux.so.2 => /lib/ld-linux.so.2 (0x40000000)
| 
| Result is: yes
| ##########################################


HAVE_XV in config.h is set according to the result of the configure-test.

Which versions have this bug?
0.50            no
CVS 20011119    yes
CVS 20011121    yes

System Info:
Debian GNU/Linux woody/testing

XFree86 Version 4.1.0.1 / X Window System
(protocol Version 11, revision 0, vendor release 6510)
Release Date: xx August 2001
gcc 2.95.4
/bin/sh is GNU bash, version 2.05a.0(1)-release (i386-pc-linux-gnu)
GNU C Library stable release version 2.2.4
GNU ld version 2.11.92.0.10 20011021 Debian/GNU Linux
GNU assembler 2.11.92.0.10 Debian/GNU Linux
Linux downhill 2.4.14badram #1 Mon Nov 19 22:25:08 CET 2001 i586 unknown

Fix1 (test for working Xv even if --enable-xv was set)
---------------------------------------------
--- configure-orig	Sat Nov 24 15:58:30 2001
+++ configure	Sat Nov 24 15:58:45 2001
@@ -1351,7 +1351,7 @@
 
 
 echocheck "Xv"
-if test "$_x11" = yes && test "$_xv" = auto ; then
+if test "$_x11" = yes && { test "$_xv" = auto || test "$_xv" = yes ; } ; then
   cat > $TMPC <<EOF
 #include <X11/Xlib.h>
 #include <X11/extensions/Xvlib.h>
---------------------------------------------

Fix2 (trust the user that if he set --enable-xv, it is really installed)
---------------------------------------------
--- configure-orig	Sat Nov 24 16:02:22 2001
+++ configure	Sat Nov 24 16:04:09 2001
@@ -1359,8 +1359,6 @@
 EOF
   _xv=no
   cc_check $_inc_x11 $_ld_x11 -lXv && _xv=yes
-else
-  _xv=no
 fi
 if test "$_xv" = yes ; then
   _def_xv='#define HAVE_XV 1'
---------------------------------------------

Thanks for your work, mplayer is great!
          cu andreas
-- 
Hey, da ist ein Ballonautomat auf der Toilette!
Echelon: sex violence tower XXX Boom human rights Islam Kate Winslet
vim:ls=2:stl=***\ Sing\ a\ song.\ ***