[MPlayer-users] [Patch] Subtitles colors problem.

[Felix Buenemann]

On Friday 26 April 2002 15:09, salvador wrote:
> [Automatic answer: RTFM (read DOCS, FAQ), also read DOCS/bugreports.html]
>
> Felix Buenemann wrote:
> > I have today applied another patch to the spudec/vobsub code, so I doubt
> > your patch will still apply.
>
> I was looking at your patch and isn't really clear some of the conditions
> you use. In any case my patch applies almost without any change.

You should discuss this with hephooey at hotmail.com, he send the patch, I just 
fixed it because of mangling by the mailer and applied it to cvs.

> Here is what I don't understand:
> Why when palette==NULL you don't copy cuspal?
> Shouldn't be like this:
>
> this->custom = custom;
> if (custom)
>    memcpy(this->cuspal ....
>
> Isn't cuspal independent of palette?
> Anyways, I'll just added a condition in your new routine to enable the
> heuristic palette only when no palette is present. I think this condition
> should be !palette *and* !cuspal, but this isn't correct with the way you
> implemented things.
>
> I'm sending the patch to the list pointed in the docs.
>
> SET

-- 
Best Regards,
        Atmos
____________________________________________
- MPlayer Developer - http://mplayerhq.hu/ -
____________________________________________