[PATCH] Re: [MPlayer-users] loader/ldt_keeper.c assumes Linux/x86

[Michael G Schwern]

On Thu, Jul 18, 2002 at 05:49:16AM -0400, mplayer-users-request at mplayerhq.hu wrote:
> On Wed, 17 Jul 2002 22:08:20 -0400 Michael G Schwern <schwern at pobox.com>
> >Hello again.  While building MPlayer, both 0.90b5 and the 20020717
> >snapshot on Debian/PowerPC, they both fall over in loader/ldt_keeper.c.
> 
> That's probably due to your
> --with-win32libdir=/usr/local/lib/win32 flag passed to configure :
> mplayer's compilation goes fine here (on a powerbook).
> 
> You can't use windows DLL's on a powerpc, they contain x86 code ;-)
> 
> ./configure --enable-gui should be ok. (undo your changes, too ;-)

Yes, configure mentions this:

    NOTE: WIN32 codec DLLs are not supported on your CPU (ppc).
    You may encounter a few AVI files that cannot be played due to missing
    opensource video/audio codec support.

and since it recognized that, I would have thought it would Do The Right
Thing and automatically disable them.

Looks like configure blindly sets win32=yes if you have --with-win32libir
set.

  --with-win32libdir=*)
    _win32libdir=`echo $ac_option | cut -d '=' -f 2`
    _win32=yes
    ;;

Oddly enough, there's a special case for qnx

    echocheck "Win32 DLL support"
    qnx && _win32=no

May as well just expand that to include all non-x86.

--- configure	2002/07/18 16:54:17	1.1
+++ configure	2002/07/18 16:57:38
@@ -3233,7 +3233,7 @@
 
 
 echocheck "Win32 DLL support"
-qnx && _win32=no
+x86 || _win32=no
 if test "$_win32" = auto ; then
   _win32=no
   if x86 ; then

After that, things build ok.

If nothing else, you might want to throw a little note on the mplayerhq.hu
download page that the Win32 codecs are x86 only, and possibly a README file
in the tarball.


-- 

Michael G. Schwern   <schwern at pobox.com>    http://www.pobox.com/~schwern/
Perl Quality Assurance      <perl-qa at perl.org>         Kwalitee Is Job One
Death?  Its like being on holiday with a group of Germans.