[MPlayer-users] Patches for changing indentation accepted?

[Fredrik Kuivinen]

On Sun, May 05, 2002 at 09:30:01AM -0300, Rogério Brito wrote:
> [Automatic answer: RTFM (read DOCS, FAQ), also read DOCS/bugreports.html]
> On May 05 2002, Arpi wrote:
> > no
> > the only case when it's acce[ted, is when the maintainer/author of a
> > code part changed indent in his own file.
> 
> 	Humm, I see. But some files are in a desperate state, needing
> 	a reindentation and better organization.
> 
> 	The file that I wanted to change had a function with many
> 	lines (which makes it hard to understand its purpose). Also,
> 	it had many long lines, which make using patches a little
> 	harder than if it had shorter lines. It would be better to
> 	have them neatly organized.
> 
> 	And the biggest problem of all was that the indentation was so
> 	strange that top-level statments of a function had no
> 	indentation at all.
> 
> 	I would like to print the code to study it well (perhaps
> 	documenting it and regarding this as a small-scale "audit" of
> 	some modules that I understand), but not having indentation
> 	makes this task take more time. :-(
>

I agree with all your points. Having this 'no cosmetic changes' rule
makes the code go into a unreadable state IMHO. One quite dirty work-
around is to run the code you want to study thru 'indent' or something
similiar and then submit patches made with 'diff -b -B'. This wont
make the code in the cvs repository any more readable though.

/ Fredrik