[MPlayer-users] bug in gtk file open dialog (patch available)

Matijs van Zuijlen Matijs.van.Zuijlen at xs4all.nl
Thu May 16 14:01:07 CEST 2002


Hello,

I'm just starting to use mplayer and I like it a lot. However, I have a
problem with the gui version. When I start gmplayer and try to load a
file using the Select file dialog, the filename it tries to open will be
a random string. By debugging, I found out that this happens because the
Gtk+ clist object containing the file names is destroyed before the
chosen name is copied from it. I was able to correct this by changing
the file Gui/mplayer/gtk/fs.c.

I am sending the output of the cvs diff command. This is the first time
ever I have sent a patch, so I can probably create a better diff file 
someone will tell me how (just tell me which FM to R, if appropriate).

BTW 1) I don't know what side-effects my change has. It looks innocent
enough (I just moved the call to HideFileSelect() down a bit), but you
never know.

BTW 2) This is yesterday's CVS code.

--- begin cvs diff output ---
cvs server: Diffing .
Index: fs.c
===================================================================
RCS file: /cvsroot/mplayer/main/Gui/mplayer/gtk/fs.c,v
retrieving revision 1.12
diff -r1.12 fs.c
339,340d338
<  HideFileSelect();
< 
377a376,378
> 
>  HideFileSelect();
> 
--- end ---

-- 
Matijs van Zuijlen

    ... designed to fill holes or cracks of not more than two cubic vims.
			    -- Robert Sheckley, Untouched by Human Hands
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 232 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-users/attachments/20020516/8d87ce73/attachment.pgp>


More information about the MPlayer-users mailing list