[MPlayer-users] color of subtitles

[Arpi]

Hi,

> >>I had a look at osd_template.c and the drawing functions don't even know 
> >>the vertical dimension of the image so currently it's impossible to make 
> >>them modify the chroma planes. So the color subtitles will require 
> >>changing every vo_* file to pass the image height too. Or can somebody 
> >>(Arpi, Michael) correct me?
> >>    
> >>
> >why do you need _height_ ?
> >
> >you actually want 3 planes instead of only one...
> >so you're right it requires API and vo_* driver modifications.
> >
> >at least for planar YUV modes. for rgb, or packed yuv it can be done now
> >  
> >
> yes, but without the height, yv12 renderer (which is uset in most cases) 
> simply doesn't know where the second and third planes begin.

hey, it don't know even if it would have teh height.

*FORGET* that U and V planes are beginning right after teh Y one...
it isn't always true, or even more valid: it's rare that true!
(yes it's true for Xv, and maybe for directfb, but false for sure in
mga/xmga, vidix, and some which uses stride!=width or planes needs to be
aligned)
so, you actually want the pointers to all 3 planes (from the caller!)
insted of the Y only. only teh caller func knows where the planes begin.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu