[MPlayer-users] Re: [PATCH] ./configure syntax error

[Diego Biurrun]

Steven M. Schultz wrote:
>>From: D Richard Felker III <dalias at aerifal.cx>
>>
>>>--- configure.dist    Tue Dec 31 14:01:41 2002
>>>+++ configure Tue Dec 31 14:01:59 2002
>>>@@ -5400,7 +5400,7 @@
>>> EOF
>>> fi
>>> 
>>>-if x86 && ! cygwin; then
>>>+if test x86 -a ! cygwin; then
>>
>>I don't think so. x86 and cygwin are function calls, not variables.
> 
> 
> 	Hmmm, then how to avoid:
> 
> ./configure: 5403: Syntax error: "!" unexpected
> 
> 	with the original "if x86 && ! cygwin; then"?
> 
> 	"test x86 -a ! cygwin"
> 
> 	should be ok.  According to the man page for test(1):
> 
> 	! expression  True if expression is false.
> 
> 	and the '-a' should be equivalent to '&&'.
> 
> 	I wonder if this is all due to 'sh' != 'bash' on some systems.   Perhaps
> 	the original 'if' uses a bash'ism?

I wrote and tested this on Cygwin, which has ash as /bin/sh.  There is 
another instance of this '!' usage in configure.  Ash is supposedly 
POSIX compliant, it works in bash also, what shell are you using?

This thread belongs on -dev-eng, please send patches there and not to 
-users.

Diego