[MPlayer-users] Re: Patch: gui and wid conflict (Was: Using -wid <id != 0> and gui=yes in config file)

[Koos Vriezen]

Zoltan Ponekker wrote:

> Arghhh.... This is wrong patch. If you read gui's config file after
> command line parsing, the common parameters is overwriting with gui's
> parameters. Rejected.

Ok, second try. Less optimal because unnecessary call to cfg_read() but
still works.

--- mplayer.c.orig      Sat Jan  4 00:19:42 2003
+++ mplayer.c   Sat Jan  4 15:11:13 2003
@@ -657,6 +657,10 @@
     if(m_config_parse_command_line(mconfig, argc, argv) < 0) exit(1); // error parsing cmdline
 #endif

+#ifdef HAVE_NEW_GUI
+    if (use_gui && WinID > 0) use_gui = 0; // no gui with -wid cmdline option
+#endif
+
     playtree = play_tree_cleanup(playtree);
     if(playtree) {
       playtree_iter = play_tree_iter_new(playtree,mconfig);


Btw, is my analysis correct that gui=yes and -wid option conflicts. I can
imagine that the gui uses the WinID as output window and don't do resizing
stuff in that case.
Either way, something must be done. This patch is the easiest.

Regards,

Koos Vriezen