[MPlayer-users] [BUG] small bug with ICONV enabled (CVS version)

[mody at quick.cz]

Hi,
I like mplayer! I've hade a problem with subtitles and while digging through
the source I've found small bug in subreader.c file. The subcp_open() method
gets called twice and because the icdsc is static one conversion descriptor
gets lost. You can see this if You use this patch.

Patrik

$ cvs diff -u subreader.c
Index: subreader.c
===================================================================
RCS file: /cvsroot/mplayer/main/subreader.c,v
retrieving revision 1.95
diff -u -r1.95 subreader.c
--- subreader.c 28 Jan 2003 18:28:09 -0000      1.95
+++ subreader.c 29 Jan 2003 09:46:32 -0000
@@ -918,6 +918,10 @@
 void   subcp_open (void)
 {
        char *tocp = "UTF-8";
+
+       mp_msg(MSGT_SUBREADER,MSGL_INFO,"SUB: about to open a iconv descriptor."
+                       "(%#x)\n", icdsc);
+
        icdsc = (iconv_t)(-1);
 
        if (sub_cp){
@@ -932,6 +936,9 @@
 
 void   subcp_close (void)
 {
+       mp_msg(MSGT_SUBREADER,MSGL_INFO,"SUB: about to close a iconv descriptor."
+                       "(%#x)\n", icdsc);
+
        if (icdsc != (iconv_t)(-1)){
                (void) iconv_close (icdsc);
                icdsc = (iconv_t)(-1);

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-users/attachments/20030129/2bb0c868/attachment.pgp>