[MPlayer-users] bug report against MPlayer-1.0pre2

[Martina und Stefan Hamacher]

Dear MPlayer-developers,

when compiling MPlayer-1.0pre2 I came across two bugs which I
would like to communicate since they do still exist in the
current cvs tree. I use cygwin/XFree86 under WinXP and applied
the following command:

   configure \
      --enable-gui \
      --enable-x11 \
      --disable-shm \
      --enable-directx \
      --enable-win32 \
      --disable-qtx \
      --disable-freetype
   make

The two modifications I needed to successfully compile the software:

a) add -lcygipc to the configure script
b) add two #ifdef/#endif statements to libmpcodecs/ve.c

aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa

Measure a) resolves undefined references to shared memory functions
like shmget() and shmctl()

My modification to configure:line_2818 which fixed the problem:

from: _ld_x11="$_ld_x11 -lXext -lX11 $_ld_sock"
to  : _ld_x11="$_ld_x11 -lXext -lcygipc -lX11 $_ld_sock"

bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb

Measure b) eliminates one undefined reference to the function
ve_info_qtvideo() which one can find in libmpcodecs/ve_qtvideo.c
but is disabled because of the earlier #ifdef USE_QTX_CODECS statement

The measure applies to libmpcodecs/ve.c:line_18ff

from:

extern vf_info_t ve_info_qtvideo;
extern vf_info_t ve_info_nuv;

static vf_info_t* encoder_list[]={
#ifdef HAVE_DIVX4ENCORE
    &ve_info_divx4,
#endif
#ifdef USE_LIBAVCODEC
    &ve_info_lavc,
#endif
#ifdef USE_WIN32DLL
    &ve_info_vfw,
    &ve_info_qtvideo,
#endif

to:

#ifdef USE_QTX_CODECS                 <<<<<<<<<<<<<<<<<<<<<<<<<<<
extern vf_info_t ve_info_qtvideo;
#endif                                <<<<<<<<<<<<<<<<<<<<<<<<<<<
extern vf_info_t ve_info_nuv;

static vf_info_t* encoder_list[]={
#ifdef HAVE_DIVX4ENCORE
    &ve_info_divx4,
#endif
#ifdef USE_LIBAVCODEC
    &ve_info_lavc,
#endif
#ifdef USE_WIN32DLL
    &ve_info_vfw,
#ifdef USE_QTX_CODECS                 <<<<<<<<<<<<<<<<<<<<<<<<<<<<
    &ve_info_qtvideo,
#endif                                <<<<<<<<<<<<<<<<<<<<<<<<<<<<
#endif

####################################################################

I would like to conclude by expressing my appreciation for the excellent
software and the professional setup which made compilation and
installation
very straightforward.

Very best regards
Hans-Peter