[MPlayer-users] error compiling: libao2: missing AFMT_U* defines

[Reimar Döffinger]

Hi,
On Fri, Dec 31, 2004 at 03:26:31PM +0100, Walter Haidinger wrote:
> FYI: There is a patch to libao2/ao_oss.c of the latest CVS tree attached.

Thanks, but we need a unified diff (diff -u ). Also they should be
ifdefed separately, with your patch nobody (at least with comercial OSS
headers) will be able to use the 24 and 32 bit formats even if the
soundcard supports it. I would suggest something like

#ifdef AF_FORMAT_U24_LE
       case AF_FORMAT_U24_LE: return AFMT_U24_LE;
       case AF_FORMAT_U24_BE: return AFMT_U24_BE;
#endif
#ifdef AF_FORMAT_S24_LE
       case AF_FORMAT_S24_LE: return AFMT_S24_LE;
       case AF_FORMAT_S24_BE: return AFMT_S24_BE;
#endif

or even

#ifdef AF_FORMAT_U24_LE
       case AF_FORMAT_U24_LE: return AFMT_U24_LE;
#endif
#ifdef AF_FORMAT_U24_BE
       case AF_FORMAT_U24_BE: return AFMT_U24_BE;
#endif
#ifdef AF_FORMAT_S24_LE
       case AF_FORMAT_S24_LE: return AFMT_S24_LE;
#endif
#ifdef AF_FORMAT_S24_BE
       case AF_FORMAT_S24_BE: return AFMT_S24_BE;
#endif

But that might be considered overkill...
If you are subscribed, you can submit the patch directly to the -dev-eng
list. Other wise I can do that.

Greetings,
Reimar Döffinger