[MPlayer-users] Latest CVS compile problem

[D Richard Felker III]

On Tue, Jan 20, 2004 at 02:11:15PM +0100, Mats Röjestål wrote:
> Hi,
> 
> 
> I get the following when i try to build from the latest CVS.
> 
> >gcc -c -O4 -march=athlon -mcpu=athlon -pipe -ffast-math 
> >-fomit-frame-pointer -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 
> >-I/usr/local/include/gtk-1.2 -I/usr/local/include/glib-1.2 
> >-I/usr/local/lib/glib/include -I/usr/openwin/include -I../loader  
> >-I/usr/local/include/gtk-1.2 -I/usr/local/include/glib-1.2 
> >-I/usr/local/lib/glib/include -I/usr/openwin/include    -o demux_mkv.o 
> >demux_mkv.c
> >In file included from demux_mkv.c:19:
> >ebml.h:4:20: stdint.h: No such file or directory
> >In file included from demux_mkv.c:27:
> >../loader/qtx/qtxsdk/components.h: In function 
> >`dump_CodecDecompressParams':
> >../loader/qtx/qtxsdk/components.h:724: warning: initialization from 
> >incompatible pointer type
> >demux_mkv.c: At top level:
> >demux_mkv.c:147: warning: #pragma pack(push[, id], <n>) is not supported 
> >on this target
> >gmake[1]: *** [demux_mkv.o] Error 1
> >gmake[1]: Leaving directory `/home/matsro/tmp/main/libmpdemux'
> >gmake: *** [libmpdemux/libmpdemux.a] Error 2
> 
> 
> there is a file stdint.h that's  missing or is this a typo?

It's breaking MPlayer policy. We use inttypes.h, not stdint.h, because
the former is more reliable. So this should be changed immediately.

Also using #pragma pack is NOT acceptable. This is MS-ism crap. If
misaligned data structures need to be read from disk (input stream),
they should be read byte-by-byte and filled into proper aligned
structures in memory. Not every platform supports misaligned structs,
and the #pragma pack method is certainly not the preferred/working way
to do it on gcc...

Rich