[MPlayer-users] Xv full screen broken in latest CVS

[Kevin O'Connor]

Hi,

When using full screen mode with Xv, the created window no longer fills the
entire screen.  This causes annoying borders to be seen on the screen even
when in full screen mode.  This is happening in the latest CVS (20040308),
and it did not happen in the latest stable release (pre3).

As an example of this, in one movie I get:

[xv] dx: 0 dy: 0 dw: 576 dh: 342
... go full screen ...
[xv] dx: 0 dy: 0 dw: 1724 dh: 1021

My monitor is 1280x1024, and a width of 1724x1021 is obviously wrong.  In
pre3 I get:

[xv] dx: 0 dy: 0 dw: 576 dh: 342
... go full screen ...
[xv] dx: 0 dy: 0 dw: 1280 dh: 1024

which is correct.  Another movie does the following:

[xv] dx: 0 dy: 0 dw: 628 dh: 508
... go full screen ...
[xv] dx: 0 dy: 0 dw: 1277 dh: 1033

The above would correctly show 1280x1024 in pre3.

I traced this problem to a commit on Feb 26th to libvo/x11_common.c between
revisions 1.163 and 1.165.  In particular reverting the following patch
fixes the problem for me:

  if(vo_x11_keepaspect)
  {
        vo_hint.flags |= PAspect;
-       vo_hint.min_aspect.x = width;
-       vo_hint.min_aspect.y = height;
-       vo_hint.max_aspect.x = width;
-       vo_hint.max_aspect.y = height;
+
+       aspect(&vo_hint.min_aspect.x, &vo_hint.min_aspect.y, vo_fs);
+       vo_hint.max_aspect.x = vo_hint.min_aspect.x;
+       vo_hint.max_aspect.y = vo_hint.min_aspect.y;
+
+       mp_msg(MSGT_VO, MSGL_V, "[x11] window aspect set to x: %d, y: %d\n",
+       vo_hint.min_aspect.x, vo_hint.min_aspect.y);
   }

-Kevin

-- 
 ---------------------------------------------------------------------
 | Kevin O'Connor                  "BTW, IMHO we need a FAQ for      |
 | kevin at koconnor.net               'IMHO', 'FAQ', 'BTW', etc. !"    |
 ---------------------------------------------------------------------