[MPlayer-users] lockless cache2 looks buggy

[Nico Sabbi]

Denis Vlasenko wrote:

>Hello mplayer coders,
>
>I was looking into cache2.c. It says that it is a lockless
>cache implementation.
>
>I see s few issues with the code. First issue is the most serious,
>since it looks like real bug.
>
>(1) Non-atomic updated of metadata.
>
>
>(2) fork() failure is not checked
>
>
>(3) Suboptimal underrun handling.
>  
>

this is a very big problem

>
>I am willing to work on this code if it is acceptable to start
>with reformatting cache2.c into more readable form first.
>Would such patch be accepted?
>
>  
>
post both (but separate) patches, please