[MPlayer-users] (lack of) code style

[Ivan Kowalenko]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Aug 19, 2006, at 13.18, Denis Vlasenko wrote:

> Hello,
>
> I took a look into mplayer source.
> Well. I saw sources of quite a number of open-source
> projects, and mplayer is definitely won't make to the
> "cleanest code" award.
>
> Two random examples:

[snip]

> What is going on with the indentation here?
> Entire mplayer.c is littered with similar things.
>

[snip]

> Gross code duplication due to excessive inlining.
>
> This is my impression from just a 5-minute cursory
> examination, so maybe I had an extremely bad luck
> of hitting the worst places to look at.

Well, try talking to the guys on the -dev mailing list. We're use  
lusers here. I'm sure a good number of us (including myself) have  
never even looked at the source.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Darwin)

iD4DBQFE6eFDh/R/wkI6oPQRArkvAJ9bvsjA31d0gjiWcX9qLDv+R0HUPgCY8+tR
lhdYBvvBJBxLjlgNW6lDTQ==
=Md32
-----END PGP SIGNATURE-----