[MPlayer-users] [PATCH] make cache2.c readable

Andrew Savchenko Bircoph at list.ru
Wed Aug 23 12:29:15 CEST 2006


> Sure. However, lines like this:
>
> if(s->read_filepos<s->min_filepos) mp_msg(MSGT_CACHE,MSGL_ERR,"Ehh.
> s->read_filepos<s->min_filepos !!! Report bug...\n");
>
> or this:
>
>       if(s->stream->type!=STREAMTYPE_STREAM ||
>           read<s->min_filepos || read>=s->max_filepos+s->seek_limit)
>
> are really hard to read because (a) '->', '>' and '>='
> look very similar without whitespace

Imho, it is easy to read this code when using *good* syntax 
highlightning (which displays pointer and logical operators with 
different colors). I think you can't change code to fit your own 
preferences.

> and (b) long lines 
> simply scroll off out of the window in my editor.

Maybe you should try word-wrap feature? I hope, your editor supports it 
properly.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-users/attachments/20060823/d13540d1/attachment.pgp>


More information about the MPlayer-users mailing list