[MPlayer-users] [PATCH] make cache2.c readable
Rich Felker
dalias at aerifal.cx
Wed Aug 23 15:43:33 CEST 2006
On Wed, Aug 23, 2006 at 02:29:15PM +0400, Andrew Savchenko wrote:
> > Sure. However, lines like this:
> >
> > if(s->read_filepos<s->min_filepos) mp_msg(MSGT_CACHE,MSGL_ERR,"Ehh.
> > s->read_filepos<s->min_filepos !!! Report bug...\n");
> >
> > or this:
> >
> > � � �if(s->stream->type!=STREAMTYPE_STREAM ||
> > � � � � �read<s->min_filepos || read>=s->max_filepos+s->seek_limit)
> >
> > are really hard to read because (a) '->', '>' and '>='
> > look very similar without whitespace
>
> Imho, it is easy to read this code when using *good* syntax
> highlightning (which displays pointer and logical operators with
> different colors). I think you can't change code to fit your own
> preferences.
>
> > and (b) long lines
> > simply scroll off out of the window in my editor.
>
> Maybe you should try word-wrap feature? I hope, your editor supports it
> properly.
Code that's not readable without a special editor is not readable.
Readable code is readable when you print it on a monochrome line
printer, edit it on a vt100, etc.
Rich
More information about the MPlayer-users
mailing list