[MPlayer-users] OSD problems with DVDs

[Nico Sabbi]

Davide Capodaglio wrote:

>My patch was intented as "working hack" or "proof of concept", not as 
>ready-to-commit-to-cvs one :-)
>Anyway I appreciate your critics and I modified it following your advices.
>
>I left open.c as it is and modified in demux_mpg.c the 
>DEMUXER_CTRL_GET_TIME_LENGTH function inside demux_mpg_control.
>Anyway I haven't found a better way to calculate the current position in the 
>main(), so I left the check of DEMUXER_TYPE_MPEG_PS and STREAMTYPE_DVD.
>
>I'm not a mplayer hacker or developer, so if you find this correct and useful 
>and you think there are better ways to integrate this into official mplayer 
>source please do it (and let me know...)
>
>I made this against 1.0-pre7try2, but I given a look also to current cvs 
>version; yes, in stream_dvd.c there's something very similar to calculate the 
>total length, but it's used only for "identify" mode.
>
>Bye
>Davide
>  
>

rejected: code duplication and no separation between mplayer core, 
stream and demuxer.
It's possible to make it better; I'm working on it